[TYPO3-core] RFC: Add icons and grouping to the page type selector

[Ingmar Schlecht]

Hi Ingo,

nice one.

Ingo Renner schrieb:
> Description:
> ============
> Jens made a nice screen where he grouped the different page types into 
> 'page', 'link', and 'special'. He also put the icons in front of the 
> labels.

Just a sidenote: Has Jens responded to our comments regarding his new 
page type icons?


> Index: t3lib/class.t3lib_tceforms.php
> ===================================================================
> --- t3lib/class.t3lib_tceforms.php	(revision 2547)
> +++ t3lib/class.t3lib_tceforms.php	(working copy)
> @@ -1546,7 +1546,7 @@
>  		$item.= '</select>';
>  
>  			// Create icon table:
> -		if (count($selicons))	{
> +		if (count($selicons) && !$config['noIconsBelowSelect'])	{

Remember to document the new TCA setting before the commit (!) in 
http://wiki.typo3.org/index.php/Pending_Documentation

> -				'default' => '1'
> +				'default' => '1',
> +				'iconsInOptionTags' => 1,
> +				'noIconsBelowSelect' => 1

By the way, I know this is a matter of taste vs. pragmatism, but I 
usually find it more handy to always add a comma in array definitions 
even after the last element. (Not important at all though.)

> -			<label index="pages.doktype.I.7">Spacer</label>
> +			<label index="pages.doktype.I.7">Visual Menu Separator</label> >
> +			<label index="pages.doktype.I.8">Link to external URL</label>



I'd prefer "Visual menu separator" in lower case, as in "Link to 
external URL". Otherwise it would have to be called "Link to External 
URL" to be consistent.

+1 based on code review.

cheers
Ingmar