[TYPO3-core] RFC #6833: Possibility to add inline JS to page

[Ingmar Schlecht]

Hi Steffen,

+1 based on reading.

But: You forgot to attach a .txt file with the doc changes for
http://wiki.typo3.org/index.php/Pending_Documentation

Some minor comments about the coding style:


> +		//add additional inline JS

Comments are indented with one more tab than the code it is describing.
(And add a space before the word "add" in the comment.)

> +		// defined in TS with page.additionalInlineJS
> +		if (is_array($GLOBALS['TSFE']->pSetup['additionalInlineJS.']))	{
> +			$GLOBALS['TSFE']->additionalInlineJS[]= $GLOBALS['TSFE']->cObj->cObjGet($GLOBALS['TSFE']->pSetup['additionalInlineJS.'],'additionalInlineJS.');
> +		}
> +		// defined in php
> +		if(is_array($GLOBALS['TSFE']->additionalInlineJS)) {
> +			foreach($GLOBALS['TSFE']->additionalInlineJS as $key=>$val) {
> +				if(!is_array($val)) {
> +					$_scriptCode .= chr(10).$val.chr(10);	
> +				}
> +			}
> +		}
> +		
>  		// Should minify?

Apparently the above comment isn't indented correctly either, so please
just correct it as well.

cheers
Ingmar

-- 
Ingmar Schlecht
TYPO3 Association Active Member