[TYPO3-core] RFC: #6825: TCEforms -- Icon for empty palettes should not be displayed

[Benjamin Mack]

Hey Masi,

ok. as you wish, there is a new patch attached. I also recoded some 
things (while/each => foreach) and made the code look good ;-)

but now that you've asked for it, you also need to test it :-P

greetings,
benni.
-SDG-

www.xnos.de // www.xnos.org


Martin Kutschker wrote:
> Benjamin Mack schrieb:
>> Hey all,
>>
>> This is a SVN patch request.
>>
>> Branches: Trunk only
>>
>> Problem:
>> when using pageTSconfig to disable certain fields that are on the second 
>> options palette, the icon to display the options palette is shown even 
>> if all 2nd options are disabled. This is totally bad if a user clicks on 
>> it and nothing happens.
>>
>> Solution:
>> Therefore we need a check to see if the palette is empty or not before 
>> rendering the "more options" icon.
> 
> Basically yes, but I think this can be done better. You render but do 
> not output with getPaletteFields(). Caching the result may be tricky and 
> an overkill. But you could at least split the function up, so that one 
> part creates only the (internal) $palParts. You can use then 
> count($palParts) instead of trim($paletteContent). So we don't have to 
> intoTemplate() if we don't need to.
> 
> Masi
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/ 
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20071124_tceforms_2.patch
Type: text/x-patch
Size: 5241 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071124/88f486bf/attachment.bin