[TYPO3-core] RFC: Bug #6688: Use the remapStack also for updated IRRE child records

[Oliver Hader]

Hi Ingo,

Ingo Renner schrieb:
> 
> Am 23.11.2007 um 21:57 schrieb Oliver Hader:
> 
> Hi Olly,
> 
>> Please test both patches (one for the Core and the other for the seminar
>> extension) attached in the bugtracker and give me some feedback.
>>
>> Finally I give my symbolic "-1" for RFC #6688. We're going to use the
>> hook variant at bug #5530 and if you confirm that it works in
>> tx_seminars, I'm going to create a new RFC here in the Core List.
> 
> * why did you put the hook in a separate method?

Hm, why not? Did you see the code in context? Before this method is a
method "hook_processDatamap_afterDatabaseOperations". Should this old
one be removed then? But I'd be fine with using the new hook in the
regular way.

> * where's the interface? - please no more method_exists in new hooks!

The result would be to check each instantiated hook objec against the
interface class and applies for whole TCEmain. Thus, all extensions
which use a TCEmain hook and were developed before TYPO3 4.2 won't work
anymore. I think this is a no-go.

By the way:
Were is a description or CGL which points out that this interface method
should be used for TYPO3 4.2 and also gives a hint on how it should be
used and implemented correctly?
If I look to class.browse_links.php, I just see the "instanceof" check
and a "UnexpectedValueException" with a string and a long number as
arguments. What does this number stand for?
Shouldn't there be something more like an exception handling? Which part
of the Core is catching and handling the exception thrown in
class.browse_links.php? If exactly this concept should also be taken for
other new hooks - is it then really good, that a wrong hook in any
extension can block the whole system?

I'm looking forward and I'm open-minded to use new techniques and to use
more OOP, because it's the right way. But it needs some more efforts
than e.g. just writing "proteced" before function names... My two cents.

You asked for the interface - here was my response... ;-)


olly
-- 
Oliver Hader
http://inpublica.de/