[TYPO3-core] RFC: clean up t3editor

Steffen Kamper steffen at sk-typo3.de
Fri Nov 23 17:38:49 CET 2007


"Oliver Hader" <oh at inpublica.de> schrieb im Newsbeitrag 
news:mailman.1.1195831501.31076.typo3-team-core at lists.netfielders.de...
> Hi Dmitry,
>
> Dmitry Dulepov [typo3] schrieb:
>> Hi!
>>
>> This is SVN patch request.
>>
>> Branch: trunk
>>
>> Problems:
>> - code does not have proper XCLASS (EM complains)
>> - ext_em_conf need updates (EM complains)
>> - PHPDocs missing
>> - function index missing
>> - name and description are not very descriptive
>> - extension requires uploadfolder and clear cache, though none is really
>> needed
>>
>> Solution: correct all this.
>>
>> Notes:
>> - if no one objects, I will commit it by the end of the day.
>> - code is reformatted by extdeveval according to coding conventions
>> - there is no icon for this extension. I have a set of nice icons and I
>> asked licensor if I can use them for TYPO3. If yes, I will provide an 
>> icon.
>>
>> Note to Tobias: great editor! But try to write code according to
>> standards from the beginning :) If you leave it for "later", it may be
>> very difficult to clean up + it takes extra time. If you write it
>> according to standards from the beginning, it will save you the most
>> valuable resource: time :) In any case - great work you did!
>
> All fine: +1
>
> Just one minimal annotation/question:
>  $code = 'blah';
>  $code.= 'moreblah';
>  $code.= 'andagain...';
> instead of
>  $code = 'blah';
>  $code .= 'blah';
>  $code .= 'andagain...';
>
> So, I'd be fine with having no space between variable name and ".="
> operator. What do you think. As I told, just a minimal tweak... ;-)
>
>
> olly
> -- 
> Oliver Hader
> http://inpublica.de/

:-) stilistic notes - i would prefer spaces for better reading (with = we 
have space too)

vg  Steffen 




More information about the TYPO3-team-core mailing list