[TYPO3-core] RFC: clean up t3editor
Ingmar Schlecht
ingmar at typo3.org
Fri Nov 23 13:50:57 CET 2007
Hi Dmitry,
generally all good, +1.
I'm just wondering why the patch extensions the whole ext_emconf.php
file, was it a line-ending problem?
cheers
Ingmar
Dmitry Dulepov [typo3] schrieb:
> Hi!
>
> This is SVN patch request.
>
> Branch: trunk
>
> Problems:
> - code does not have proper XCLASS (EM complains)
> - ext_em_conf need updates (EM complains)
> - PHPDocs missing
> - function index missing
> - name and description are not very descriptive
> - extension requires uploadfolder and clear cache, though none is really
> needed
>
> Solution: correct all this.
>
> Notes:
> - if no one objects, I will commit it by the end of the day.
> - code is reformatted by extdeveval according to coding conventions
> - there is no icon for this extension. I have a set of nice icons and I
> asked licensor if I can use them for TYPO3. If yes, I will provide an icon.
>
> Note to Tobias: great editor! But try to write code according to
> standards from the beginning :) If you leave it for "later", it may be
> very difficult to clean up + it takes extra time. If you write it
> according to standards from the beginning, it will save you the most
> valuable resource: time :) In any case - great work you did!
>
--
Ingmar Schlecht
TYPO3 Association Active Member
More information about the TYPO3-team-core
mailing list