[TYPO3-core] RFC: Feature #6635: Allow dynamic values in TCAdefaults - Cleaned up patches

Christian Trabold christian.trabold at dkd.de
Thu Nov 22 16:31:23 CET 2007


Hi,

>> @Diff-File: Is there a problem with the diff I don't see? I made the 
>> diff against head with Eclipse "Team > Create Patch"... as usual.
> 
> No, no. Technicall the diff is fine. it's just that some results of diff 
> are not easy to understand, because the changes are scattered etc. In 
> your case the blocks of changes (the loop) are spread to to and bottom 
> of the diff with the hook in the middle. So it's not easy to compare the 
> old and the new version of the foreach loop.

I divided the changes into several files:


The patch "6635_class.t3lib_transferdata_v2.patch" implements the 
userFunc feature WITHOUT any cleanup. As you can see it produces 
double-code which can be avoided as follows:


1) Reduce the code with patch "6635_class.t3lib_transferdata_cleanup.patch":


This patch implements the cleanup for Wolfgangs patch [1].


*Question*
- Should this become a new RFC? I tried to attach a note into the 
bugtracker [1], but this is not possible for resolved / closed issues :-/

- Shall I create a new issue in the bugtracker for this patch?



2) Add the new userFunc-Feature with the patch 
"6635_class.t3lib_transferdata_v3.patch":

This patch implements the userFunc-Feature into the cleanedup code.



Greetings

Christian


[1] http://bugs.typo3.org/view.php?id=1919
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6635_class.t3lib_transferdata_cleanup.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071122/57adfeee/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6635_class.t3lib_transferdata_v2.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071122/57adfeee/attachment-0001.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6635_class.t3lib_transferdata_v3.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071122/57adfeee/attachment-0002.txt 


More information about the TYPO3-team-core mailing list