[TYPO3-core] RFC: #6259 Disabling Tabs with no fields II

[Dmitry Dulepov [typo3]]

Hi!

Malte Jansen wrote:
> This is an SVN patch request.

I am looking to the patch at the moment. Found a couple of minor things that are related to formatting.

My editor complains about inconsistent line endings :( Must be Unix file format!

We do not use Hungarian notation for variable names, so $sContent should be $content before comitting.

In this block:

@@ -3933,7 +3937,7 @@
 	 */
 	function getDynTabMenu($parts, $idString) {
 		if (is_object($GLOBALS['TBE_TEMPLATE']))	{
-			return $GLOBALS['TBE_TEMPLATE']->getDynTabMenu($parts, $idString);
+			return $GLOBALS['TBE_TEMPLATE']->getDynTabMenu($parts, $idString, 0,FALSE,50,1,FALSE,1, $this->dividers2tabs);

Last line has inconsistent spacing. Generally we put a space after comma. Please, follow that.

I tried to apply patch after looking at it but it fails to apply to current trunk. I tried to get revision 2709 but it fails for that revision too:
------------------
(Stripping trailing CRs from patch.)
patching file t3lib/class.t3lib_tceforms.php
Hunk #5 FAILED at 648.
Hunk #6 succeeded at 3935 (offset -2 lines).
1 out of 6 hunks FAILED -- saving rejects to file t3lib/class.t3lib_tceforms.php.rej
(Stripping trailing CRs from patch.)
patching file typo3/template.php
Hunk #1 FAILED at 1392.
Hunk #2 FAILED at 1415.
Hunk #3 FAILED at 1427.
Hunk #4 FAILED at 1552.
4 out of 4 hunks FAILED -- saving rejects to file typo3/template.php.rej
(Stripping trailing CRs from patch.)
patching file typo3/sysext/t3skin/stylesheets/typo3-dyntabmenu.css
Hunk #1 FAILED at 19.
Hunk #2 FAILED at 34.
2 out of 2 hunks FAILED -- saving rejects to file typo3/sysext/t3skin/stylesheets/typo3-dyntabmenu.css.rej
------------------

Can you update to current trunk and repost the patch?

-- 
Dmitry Dulepov
TYPO3 freelancer / TYPO3 core team member
Web: http://typo3bloke.net/
Skype: callto:liels_bugs