[TYPO3-core] RFC: Hook request for t3lib_befunc + t3lib_userauthgroup

Ingo Renner ingo at typo3.org
Sat Nov 17 13:29:32 CET 2007


Hi Bernhard,

* please use php5 method and variable declarations
* use more speaking variable names, do not strife for shortness but for 
clarity f.e. $curID => $current(What ID, page, user, news?)ID
* phpDoc for classes needs to go directly above them
* evalConditionStr() => evalCondition()

Other than that the patch looks ok, but I'm not sure whether it's good 
to duplicate code... could you team up with Olly maybe?

all the best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2


More information about the TYPO3-team-core mailing list