[TYPO3-core] RFC: #6259 Disabling Tabs with no fields (does not work)

[Tapio Markula]

Malte Jansen kirjoitti:
> 
> Ingmar Schlecht schrieb:
>> Hi Malte,
>>
>> Malte Jansen schrieb:
>>>> I'm actually in favour of completely removing them always when they're
>>>> empty. What do you think?
>>>>
>>> So my idea would be, that div2tabs has one addition option:
>>> divs2tabs = 0 (off)
>>> divs2tabs = 1 (activ I)
>>> divs2tabs = 2 (activ II)
>>
>> Sounds reasonable.
>>
>> Can you prepare a patch and the necessary documentation changes?
>>
>> cheers
>> Ingmar
>>
> 
> Hi,
> here is the new patch.
> 
> Cheers,
> 
> Malte
> 

should rather be


				$isEmpty = strcmp(trim($def['content']),'');
					// "Removes" empty tabs
				if (!$isEmpty && $dividers2tabs == 1) {
					continue;
				}
endeed the variable should be rather $isNonEmpty, when it has more sense

$isNonEmpty = strcmp(trim($def['content']),'');
					// "Removes" empty tabs
				if (!$isNonEmpty && $dividers2tabs == 1) {
					continue;
...
<td class="'.($isNonEmpty ? 'tab' : 'disabled')...
				}