[TYPO3-core] RFC: installer doesn't honour fourceCharset (bug #1358)

[Ingmar Schlecht]

Hi Masi,

Martin Kutschker wrote:
> Martin Kutschker schrieb:
>> Hi!
>>
>> Branch: trunk, TYPO3_4-1
>>
>> Problem: you cannot enter a site name (or other strings) in the
>> installations charset as forceCharset is ignored.
>>
>> Solution: use forceCharset
> 
> This version also sets the HTTP header in the installer and for the
> login screen.

I'm generally +1 to the idea, and it should be kept in memory for the
new installer (I don't know if it respects the forceCharset already).

Anyway, the patch has some issues:

There's a line break in the middle of:

> +			($GLOBALS['TYPO3_CONF_VARS']['BE']['forceCharset']?$GLOBALS['TYPO3_CONF_VA
> +RS']['BE']['forceCharset']:'iso-8859-1'));

> -					'Copyright © '.TYPO3_copyright_year.' Kasper Skårhøj. Extensions are copyright of their respective owners. '.
> +					'Copyright © 1998-2006 Kasper Skårhøj. Extensions are copyright of their respective owners. '.

The line with '.TYPO3_copyright_year.' was replaced with the old
hardcoded version. Seems like your patch was based on an older revision.

Other than that, +1 based on reading.

cheers
Ingmar

-- 
Ingmar Schlecht
TYPO3 Association Active Member