[TYPO3-core] RFC: Feature #6662 Introducing new doktype "Container Page", tabs in Pagerecords and moving Advanced Page to normal

[Ingo Renner]

Hi Steffen,


you're mixing two different issues in one RFC, please split them in two 
or even three.

* Adding tabs (that'd be an easy and quick one I guess)
* removing the advanced doktype
* introducing the new container doktype (maybe container is a confusing 
word, too as this is not was it does, I'd suggest 'content replica' for 
example)


Other from that here're some comments on your patch:

* your patch must be rooted in the TYPO3 installation root
* it's lowercase array() and booleans true/false
* when changing the label references locallang_* you can also change 
them from .php to .xml
* please watch your line endings (patch lines 101-103)
* operators like + - < > and so on need a space before and after them
* in functions, arguments a separated by a comma followed by space _, _
* the introduction of the new doktype also needs an update wizard for 
changing existing pages using the show content from field to the new one 
I guess
* in you update class, change the copyright to you and update the year 
(that would be 2007 only since the file is new)
* please add a more detailed and descriptive "description" to the update 
wizard class
* store your result in a variable and do only have a single return in 
your update class per method
* use php5 in your update class adding public/private keywords
* add proper phpDoc comments to your methods


all the best
Ingo

-- 
TYPO3 Core Developer, Release Manager TYPO3 4.2