[TYPO3-core] RFC: Make image hash names longer to avoid collisions
Karsten Dambekalns
karsten at typo3.org
Wed May 16 14:55:33 CEST 2007
Hi.
Type: bugfix, somewhat
Branches: all 4.x if you like
We recently saw some cases of wrong images being displayed. After
investigating we concluded that the only possible explanation could
be a name collision, because two different images got the same short
md5 hash as generated filename.
This possible problem has been discussed back in 2004, btw: http://
lists.netfielders.de/pipermail/typo3-dev/2004-July/004597.html
The attached patch fixes the issue for me, the length of the hash in
then configurable via TYPO3_CONF_VARS, default stays with 10 chars to
make sure nothing changes. For trunk we could make this 32, I'd say.
Names will then have longer md5 names, massively reducing the risk of
name collisions.
Regards,
Karsten
--
Karsten Dambekalns
Gimme Five!
http://typo3.org/gimmefive
-------------- next part --------------
A non-text attachment was scrubbed...
Name: img-hashlength-4x.diff
Type: application/octet-stream
Size: 3700 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070516/40ffede5/attachment.obj
-------------- next part --------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 304 bytes
Desc: This is a digitally signed message part
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070516/40ffede5/attachment.pgp
More information about the TYPO3-team-core
mailing list