[TYPO3-core] RFC: Bug 5550: 'lower' TCA specification may fail with non-ascii characters

Martin Kutschker Martin.Kutschker at n0spam-blackbox.net
Mon May 7 17:13:51 CEST 2007


Dmitry Dulepov schrieb:
> Martin Kutschker wrote:
>> +1, but I note that you use "$LANG". AFAIR the seem to be a preference 
>> for $GLOBALS['LANG'] if the object is not used very often (more than 4 
>> times???).
> 
> I used that in the very first version but then I decided that
> 
>     $LANG->csConvObj->conv_case($LANG->charSet, $value, 'toUpper');
> 
> is a little easier to understand than
> 
>     $GLOBALS['LANG']->csConvObj->conv_case(
>         $GLOBALS['LANG']->charSet, $value, 'toUpper');
> 
> It makes exactly 4 times in the code.
> 
> I am also in favor of $GLOBALS (because it is easier to track) but here 
> are went for more simple code.

I don't care much. I like "global $VAR" more because it's generally 
shorter. I only pointed it out because I remembered the discussion and I 
feel that a consitent use of a language feature increases maintainability.

Masi


More information about the TYPO3-team-core mailing list