[TYPO3-core] RFC: Bug 4623: Content encoding with x-gzip not possible in IE7

Michael Stucki michael at typo3.org
Tue May 1 18:31:39 CEST 2007


Thank you! +1 (though untested - I have no IE7 here)

Since we discussed this at T3DD, you can also commit it to the TYPO3_4-0
branch now...

- michael

Oliver Hader wrote:

> Hi Michael,
> 
> Michael Stucki wrote:
>> So then you are having a typo here:
>> +       // Furthermore a qvalue check is done. "gzip;q=0" means to gzip
>> accepted to gzip => no gzip
>> 
>> +       $acceptEncoding = $GLOBALS['_SERVER']['HTTP_ACCEPT_ENCODING'];
>> As far as I know, $_SERVER is always superglobal, so no need to prepend
>> it with $GLOBALS.
> 
> Changed these two things. HTTP_ACCEPT_ENCODING is now taken from
> t3lib_div::getIndpEnv() (and added there).
> 
>> What will be the next misbehaviour of MSIE? Probably you should already
>> make the preg_match() case insensitive...?
> 
> Hm, I applied the "/.../i" modifier to the regexp. I hope that MSIE will
> support a minimum of standard and thus keep the settings in lowercase.
> But who knows...
> 
>> One more note: You could add HTTP_ACCEPT_ENCODING to
>> t3lib_div::getIndpEnv() so it could be wrapped - if needed - in future.
> 
> I had this in the first patch available in the bugtracker. Now I added
> this again to t3lib_div::getIndpEnv() as mentioned above.
> 
>>> Branches: Trunk & TYPO3_4-1 & TYPO3_4-0
>> 
>> I think it's not needed in TYPO3_4-0.
> 
> Well, initially the bug was reported for 4.0.2. Concerning the release
> of TYPO3 4.0.6, I thought this could also be part of that (possibly
> last) version of the 4.0 branch. But it's not absolutely necessary...
> 
> I attached the corrected patches.
> 
> 
> olly

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list