[TYPO3-core] RFC: Bug 4623: Content encoding with x-gzip not possible in IE7

[Oliver Hader]

Hi Michael,

Michael Stucki wrote:
> So then you are having a typo here:
> +       // Furthermore a qvalue check is done. "gzip;q=0" means to gzip accepted
> to gzip => no gzip
> 
> +       $acceptEncoding = $GLOBALS['_SERVER']['HTTP_ACCEPT_ENCODING'];
> As far as I know, $_SERVER is always superglobal, so no need to prepend it
> with $GLOBALS.

Changed these two things. HTTP_ACCEPT_ENCODING is now taken from
t3lib_div::getIndpEnv() (and added there).

> What will be the next misbehaviour of MSIE? Probably you should already make
> the preg_match() case insensitive...?

Hm, I applied the "/.../i" modifier to the regexp. I hope that MSIE will
support a minimum of standard and thus keep the settings in lowercase.
But who knows...

> One more note: You could add HTTP_ACCEPT_ENCODING to t3lib_div::getIndpEnv()
> so it could be wrapped - if needed - in future.

I had this in the first patch available in the bugtracker. Now I added
this again to t3lib_div::getIndpEnv() as mentioned above.

>> Branches: Trunk & TYPO3_4-1 & TYPO3_4-0
> 
> I think it's not needed in TYPO3_4-0.

Well, initially the bug was reported for 4.0.2. Concerning the release
of TYPO3 4.0.6, I thought this could also be part of that (possibly
last) version of the 4.0 branch. But it's not absolutely necessary...

I attached the corrected patches.


olly
-- 
Oliver Hader
http://inpublica.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004623_v3_w.patch
Type: text/x-diff
Size: 5388 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070330/0c7114d5/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004623_v3.patch
Type: text/x-diff
Size: 24023 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070330/0c7114d5/attachment-0003.bin