[TYPO3-core] RFC: htmlArea RTE Position Accessibility icons

Patrick Broens patrick at patrickbroens.nl
Thu Mar 8 16:23:01 CET 2007


Ernesto Baschny [cron IT] wrote:
> Patrick Broens wrote: on 23.02.2007 08:54:
> 
>>>> Problem:
>>>> In the extension configuration of htmlArea RTE is an option to add
>>>> accessibility icons in front of the links. However, these icons are
>>>> normally behind the link and not in front. We need to stick to the
>>>> guidelines and what people are used to.
>>>>
>>>> Solution:
>>>> I would like to add an extra option that puts the icons behind the links
>>>> instead of in front of them. Administrators can still choose whether
>>>> they want the icons in front or after the link.
>>>>
>>>> Additionally the current icons are not according the guidelines and are
>>>> not representing their functionality. I would like to change them, but I
>>>> think that can cause problems with existing websites. Therefor I would
>>>> like to add new icons to the extension and refer to them in the manual
>>>> how to change the default set.
> 
> I just saw your suggested icons, and I also like them. Maybe you should
> just provide them in form of a extension in TER, which contains the
> files and the proper PageTS to make use of them so one can install the
> extension and start using the new icons right away.
> 
>>> - it does not seem to work here on my setup. In PageTS I can see that
>>> RTE.classesAnchor.xxx.iconBehindLink = 1 is set for all types of links.
>>> I reloaded everything from the server (no proxies, ctrl-reload in IE).
>>> But images are still being placed before the link text.
> 
>> Delete all javascript files related to rtehtmlarea in typo3temp.
> 
> Ok, it works, thanks for the tip! Works fine. So +1 from me, with the
> mentioned modifications (maybe you could repost the patch here with the
> modifications so that others can review it).
Modifications are done. Here is the repost.
> 
> Currently these helper images are hardcoded inside the content elements
> and one cannot modify (or even remove) these globally. Therefor in the
> long term I would rather like to see this functionality as part of
> typolink. So parseFunc_RTE could generate those different
> prefixed/suffixed images based on the type of the link at render time.
> This would be a better way to separate the content (just links with a
> class-specifier) and the design. Changing the icon set or removing this
> image from the FE-output is then just a matter changing a switch somewhere.
> 
>> They
>> are created when a new version of rtehtmlarea is installed an run for
>> the first time. After this, the files are not generated anymore unless
>> they are not present in the typo3temp directory anymore. They don't have
>> to, when the version is still the same. In the case of this code review,
>> the version hasn't changed as well, so you need to delete them manually
>> when reviewing.
> 
> True. Any special reason why the used scripts are copied to typo3temp? I
> guess to avoid the browser to use old cached scripts, right? Isn't that
> a functionality that others extensions might also make use of? As far as
> I can see this is currently implemented in
> class.tx_rtehtmlarea_base.php. Could be a candidate for t3lib_div.
> 
> Cheers,
> Ernesto

Cheers,

Patrick

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtehtmlarea_accessibilityicons.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070308/304dc412/attachment-0001.diff 


More information about the TYPO3-team-core mailing list