[TYPO3-core] RFC: Bug 4814: Umlauts error in AJAX Pagetree (4.1beta3)

[Ernesto Baschny [cron IT]]

Oliver Hader wrote: on 25.01.2007 15:23:

> Problem:
> On expanding a subtree in the pagetree, special characters like umlauts
> are not displayed correctly due to a missing charset handling. The
> branch of a tree to be expanded is fetched using an AJAX call.
> 
> Solution:
> Add utf-8 encoding for the AJAX response using csConvObj->utf8_encode
> and integrate a fixed HTTP header.
> 
> Bugtracker reference:
> http://bugs.typo3.org/view.php?id=4814
> 
> Comments:
> This issue and its solution is similar to RFC for bug 4820 ("IRRE -
> Wrong character encoding in AJAX response").
> In the attached patch furthermore some parts were disabled, that are not
> necessarry for AJAX calls (e.g. instantiate 'template' in $this->doc).
> 
> Branch:
> Trunk


The patch is a bit difficult to review, because you also fixed some
indening problems. Next time you could try to make two patches, like
Stucki uses to do: one the original "to be commited" patch (-u) and
another skipping blank-diffs (with -b), so that we can review that more
easily.

But it solved the problem nicely, +1 from me too.

Cheers,
Ernesto