[TYPO3-core] RFC: EM: inconsistent line ending while saving ext_emconf.php
Thomas Hempel
thomas at work.de
Wed Jan 24 11:35:11 CET 2007
Hi,
>
> Problem: while updating ext_emconf.php on Windows, EM creates
> inconsistent file endings: part of the file has only \n, another part
> has \r\n. This prevents committing extension files to SVN.
>
> Solution: use preg_replace() to remove \r.
>
> Note: I also fixed uninitialized variables usage in that file. This is
> too trivial to supply as separate patch. Basically $absPath and
> $emConfFileName were defined inside "if" but were used also inside
> "else". I just moved them out of condition.
+1 after reading the patch and checking the else part in the code.
Greets,
Thomas
More information about the TYPO3-team-core
mailing list