[TYPO3-core] RFC: links with forced type 0

Thorsten Kahler thorsten.kahler at dkd.de
Wed Jan 3 13:57:24 CET 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ingmar,

Ingmar Schlecht wrote on 03.01.2007 12:17:
>> -		if (!$typeOverride && intval($GLOBALS['TSFE']->config['config']['forceTypeValue']))	{
>> +		if ($typeOverride==='' && intval($GLOBALS['TSFE']->config['config']['forceTypeValue']))	{
> 
> That's wrong, because even if $typeOverride would be NULL of FALSE, it
> would not take the default value defined in
> $GLOBALS['TSFE']->config['config']['forceTypeValue'].
> 
> Please use !t3lib_div::testInt($typeOverride) instead.
> 

you're right. I didn't think of someone who might (mis)use the function that
way. To check the parameter with testInt() is the safer way.

Changed diff attached.

Regards
Thorsten

- --
Thorsten Kahler
thorsten.kahler at dkd.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFFm6gxmfCxYiz3uLkRAvlaAJ4wIapbe/V2bAOZh7tBnfyw4kPXMACfU3Qu
Zmz9csXTHzc95t7yKwitj54=
=XzpR
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: forceTypeValue_fix-2.diff
Type: text/x-patch
Size: 809 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070103/cd9a83ae/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: forceTypeValue_fix-2.diff.sig
Type: application/octet-stream
Size: 65 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070103/cd9a83ae/attachment.obj 


More information about the TYPO3-team-core mailing list