[TYPO3-core] RFC: Bug #4951: SQL error when editing BE User
Oliver Hader
oh at inpublica.de
Tue Feb 20 13:55:25 CET 2007
Hi Michael,
Michael Stucki wrote:
> Hi Olivier,
>
>> Michael Stucki wrote:
>>> This is a SVN patch request.
>>>
>>> + if ($TCA[$table]['ctrl']['versioningWS']) {
>>> + $pid_list_tmp = preg_replace('/^\-1,/','',$pid_list_tmp);
>>> + }
>> Hm, shouldn't it be "if (!$TCA[$table]['ctrl']['versioningWS'])"?
>> If workspaces are not allowed for the table the "-1" isn't as well.
>
> Ouch! Of course you are right. I'll change my patch right away. See fixed
> version attached.
>
> Btw. for those who cannot reproduce the problem: You can test it by calling
> debug after each of these calls and opening
> Tools -> DB check -> Record statistics
Thanks for the change. I think there is something more missing.
In typo3/lowlevel/dbint/index.php "$admin->countRecords($id_list)" is
called again with "-1,0". Could you also have a look at this? Thanks!
But in general the patch looks good and works.
olly
--
Oliver Hader
http://inpublica.de/
More information about the TYPO3-team-core
mailing list