[TYPO3-core] RFC: Cleanup in tslib_menu / add new property "additionalParams"

Patrick Broens patrick at patrickbroens.nl
Mon Feb 5 13:51:58 CET 2007


Hi Stucki,

Michael Stucki wrote:
> Hi Martin,
> 
> Martin Kutschker wrote:
>> +1 (untested)
> 
> Thanks!
> 
>> I notice that you changed "$res = $this->result;"
>>   to "$res = &$this->result;". Does it change the behaviour or is the
>> assignement to $res only to make the code shorter (avoiding lenghthy
>> repetitions of $this->result).
> 
> Of course it doesn't! It's just used as a shortcut, no write changes occur.
> 
>> PS: I fail to see some of the WS changes. What did you change? You did
>> not eg add spaced in terms like that $x="y" to $x = 'y'.
> 
> Don't get that, what do you mean? Yes I changed some $x='y' to $x = 'y' but
> what should be wrong with that?
Some lines in the diff seem to have changed because they are deleted and 
added again, with no visible change and no reason at all. Could be the 
removal of some trailing white spaces, although I can't see it.
> 
> - michael
> 
> PS: Still one +1 needed...
+1 from me, but untested

Patrick


More information about the TYPO3-team-core mailing list