[TYPO3-core] RFC: Bug 3069: Extension manager crashes

[Michael Stucki]

I tracked this issue down with Ingmar who found one of his installations
which is affected by this bug (he didn't know that before ;-))

So finally, we found a cleaner solution to the problem, and Ingmar could
even confirm that it is working fine.

See attached patch V3. Look at _w but test the other one.

Branches: Still TYPO3_4-0 and Trunk.

- michael

Ingmar Schlecht wrote:

> Hi Stucki,
> 
> wouldn't a simple
>    if(!$versionRange[0]) $versionRange[0] = 0;
>    if(!$versionRange[1]) $versionRange[0] = 0;
> have fixed the problem as well?
> 
> And apart from that, you always changed
>    if(...)
> to
>    if($versionRange[x] && ...)
> 
> but wouldn't it be more accurate to sometimes use the && operator and
> sometimes the || operator depending on whether version_compare() is
> called with '>' or with '<' as its third parameter?
> 
> cheers
> Ingmar
> 
> Michael Stucki wrote:
>> This is a SVN patch request.
>> 
>> Problem:
>> The extension manager crashes on some systems.
>> 
>> Solution:
>> As it seems, some older PHP versions have a problem if version_compare()
>> is called with an empty argument.
>> 
>> Meanwhile this problem does not occur anymore (PHP 4.3.0+) but I think it
>> is cleaner anyway to check first if the value is true...
>> 
>> Bugtracker reference:
>> http://bugs.typo3.org/view.php?id=3069
>> 
>> Branches:
>> TYPO3_4-0 & Trunk
>> 
>> Comments:
>> This issue was solved by Rainer Härtlein.
>> 
>> - michael
> 

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_3069_v3.diff
Type: text/x-diff
Size: 10852 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070204/5d223c79/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_3069_v3_w.diff
Type: text/x-diff
Size: 2757 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20070204/5d223c79/attachment-0001.bin