[TYPO3-core] RFC: code cleanup: #6990 use prototype functions instead of own ones where possible in clickmenu

Malte Jansen mail at maltejansen.de
Mon Dec 17 14:41:21 CET 2007


Oliver Hader schrieb:
> Hi Helmut,
> 
> Helmut Hummel schrieb:
>> Hi there,
>>
>> this is a SVN patch request.
>>
>> Type: Cleanup
>> BT reference: http://bugs.typo3.org/view.php?id=6990
>>
>> Problem:
>> In clickmenu.js the window object is extended by two functions
>> window.getDimensions and window.getScrollOffset.
>> Both are already supported by prototype framwork with identical function
>> names and very similar code, so no need for own functions here.
>>
>> Solution: Use document.viewport.getDimensions() and
>> document.viewport.getScrollOffsets() instead.
>>
>> Comment:
>> This is a code cleanup, with low priority
>>
>> Tested with FF2, IE6, Safari 3 (Windows)
> 
> +1 on reading and testing
> 
> olly

Hi,

+1 on reading and testing with FF2

Cheers,

Malte


More information about the TYPO3-team-core mailing list