[TYPO3-core] RFC: code cleanup: #6990 use prototype functions instead of own ones where possible in clickmenu

Helmut Hummel typo3 at jhpc.de
Mon Dec 17 14:05:59 CET 2007

Hi there,

this is a SVN patch request.

Type: Cleanup
BT reference: http://bugs.typo3.org/view.php?id=6990

In clickmenu.js the window object is extended by two functions
window.getDimensions and window.getScrollOffset.
Both are already supported by prototype framwork with identical function
names and very similar code, so no need for own functions here.

Solution: Use document.viewport.getDimensions() and
document.viewport.getScrollOffsets() instead.

This is a code cleanup, with low priority

Tested with FF2, IE6, Safari 3 (Windows)

lib.salutation = TEXT
lib.salutation.value = Kind regards, Helmut
lib.salutation.lang.de = Viele Grüße, Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6990_cleanup.diff
Type: text/x-patch
Size: 2025 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071217/23893468/attachment.bin 

More information about the TYPO3-team-core mailing list