[TYPO3-core] RFC: Bug #6921: localize harcoded labels in t3lib/stddb/tbl_be.php

[Patrick Rodacker]

Hi Ingo,

Ingo Renner wrote on 13.12.2007 17:35:

> first, thanks for your effort as this probably was a quite boring task!

indeed, but it is okay to get used to the whole core patching mechanism
and to gain some insight of the internals ;-)

>> Solution:
>> Localize labels and create entries in typo3/sysext/lang/locallang_tca.xml
> 
> on line 73, 341, 350 of your patch: was it supposed to be be_users.* or 
> did you reuse an existing label?
> - same for be_groups on lines 395, 403, 412, 430, 439, 446-448

all these labels are used in be_users and be_groups and therefore
weren't prefixed with the table name. See lines 786-799 of the attached
patch.


> On lines 633, 642 it seems that you didn't delete the hard coded label
> 
> lines 819 and 820 are duplicates

deleted the old entries and removed the duplicate labels.

> line 377: how has this label been replaced?

It wasn't displayed anywhere, so I removed it.


>> Notes:

>> * localized language names are taken from
>> typo3/sysext/setup/mod/locallang.xml
> 
> I'm not quite sure whether we should do this.

me neither, but there isn't any place these labels could be found, so I
used the only existing ones. Next step would be to move the keys from
typo3/sysext/setup/mod/locallang.xml to a more global place and change
the calling entries.

I have attached the updated patch.

Greetings
Patrick

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0006921_v2.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071213/e90e651b/attachment-0001.txt