[TYPO3-core] RFC: Bug 1655: Allow HTTPS in t3lib_div::substUrlsInPlainText()

Michael Stucki michael at typo3.org
Fri Sep 1 01:14:02 CEST 2006


Reminder #2

Can someone please test this?

- michael

Michael Stucki wrote:

> Alright, thanks for the notice. Attached is a new patch based on Masis
> suggestion.
> 
> Use bug_1655_makeredirect_useHTTPS_v3_w.diff to see the differences.
> Use bug_1655_makeredirect_useHTTPS_v3.diff to try it out.
> 
> - michael
> 
> Martin Kutschker wrote:
> 
>> Sebastian Kurfuerst schrieb:
>>> Hi,
>>> 
>>> -1 stop!
>>> 
>>> I made a mistake.. The patch would replace every http or https url with
>>> http/https depending on the server setting.
>>> 
>>> So imagine you had an SSL server and a non-ssl URL, you would get an ssl
>>> url instead.
>> 
>> Oops, you right.
>> 
>> I guess the protocol of the link should be preserved. So we need two
>> loops, one for each protcol:
>> 
>> foreach (array('http','https' /* ,'ftp' */) as $protocol) {
>>   $urlSplitexplode($protocol.'://',$message);
>>   ...
>> }
>> 
>> Masi
> 

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_1655_makeredirect_useHTTPS_v3_w.diff
Type: text/x-diff
Size: 2158 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060901/c4b60a77/attachment.bin 


More information about the TYPO3-team-core mailing list