[TYPO3-core] RFC: Bug #4515: Date fields displayed wrong in TCEforms

Michael Stucki michael at typo3.org
Fri Nov 17 20:07:09 CET 2006


Hi Ernesto,

> +1 from me too, but with some modifications:
> 
> I just don't agree with that part:
> -                                               $value =
> date($option,$itemValue);
> +                                               $value =
> date('d-m-Y',$itemValue);
> 
> Why are you not using $option anymore? I don't know where this
> $config['format.']['option'] comes from, is it documented somewhere? Can
> this be set through TCA? How?

I didn't change that! It just looks like this since the indentation has
changed. Have a look at the *_w.diff patch to see the real changes made.

> And while you are at it, the same problem arises if the format is
> datetime, time, timesec and year. So I would propose to simplify the
> patch by doing right before the switch something like:
> 
> if (!$itemValue && in_array($format, array('date', 'datetime', 'time',
> 'timesec', 'year'))) {
>    return '';
> }

You can do that later if you like, I'm just happy to get my todo list
smaller... :-)

Committed to TYPO3_4-0 and Trunk.

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/



More information about the TYPO3-team-core mailing list