[TYPO3-core] RFC: Fix bug #1153 again: Adding parameters is not always expected

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Wed Jun 28 22:17:55 CEST 2006


Michael Stucki schrieb:
> Hi Martin,
> 
> this seems still pending...
> 
>>> Problem:
>>> In bug #1153 I did add the parameters of the showpic.php script to the
>>> alternative script if set by "JSwindow.altUrl". This works as expected,
>>> but users have asked to prevent this behaviour because they construct the
>>> parameters using a postUser function for example.
>>>
>>> Solution:
>>> We need a new property to prevent addition of the parameters.
>> This patch reverts to the old bahaviour, but adds
>> JSwindow.altUrlAppendDefParams.
> 
> This is still in contrary to my other suggestion (attached again).
> 
> Well, yes it seems I broke the compatbility with this change. Sorry for
> that. However, is it worth to revert back to the old behaviour (changing
> this once again) while it is anyway easier to use for everybody except
> those who build the URL with this userFunc? I doubt if this is worth the
> complication...
> 
> The name of your property reminds me of this quote (taken from your reply to
> my original solution):
> 
> | >> "JSwindow.altUrl_dropParams"
> | >
> | > It's just a matter of style but could we either use caps or underscores?
> | > I don't care. But using them both in one name is hurtung my eyes ;-) 
> 
> To me this makes clear that "dropParams" is just a subproperty of the
> "altUrl" property. I like that separation.

Ok, I give in. A last suggestion is JSwindow.altUrl_noDefaultParams 
(Variant names: no<>drop, Default<>Def). The "default" shall make it 
clear what params are to be dropped.

Masi



More information about the TYPO3-team-core mailing list