[TYPO3-core] RFC: allow access from private nets

Martin Kutschker Martin.Kutschker at n0spam-blackbox.net
Wed Jun 28 14:32:55 CEST 2006


Michael Stucki schrieb:
> Hi Martin,
> 
> I think that instead of allowing a whole network to access the install tool,
> it would be much better to allow access based on the existance of a simple
> file.
> 
> The attached patch removes the IP check in the install tool and just checks
> for the existance of typo3conf/ENABLE_INSTALL_TOOL instead.

How about this check?

($_SERVER['REMOTE_ADDR']!='127.0.0.1' && $_SERVER['REMOTE_ADDR']!='::1') || 
!@is_file($enableInstallToolFile)

It uses the file thingy for remote access but still allows for localhost.

The 0==1 or 1==2 check is IMHO pointless as those who can code can change 
the check and those that can't have no idea what to change.

Masi



More information about the TYPO3-team-core mailing list