[TYPO3-core] Reminder: : pageNotFound_handling HTTP status fix

Dmitry Dulepov typo3 at accio.lv
Fri Jun 23 22:29:40 CEST 2006


Hi!

Martin Kutschker wrote:
> You have again placed the check for function_exists('file_get_contents') 
> wrongly.

I see... I based my patch on 404_v2.txt, so did not see your changes.

> BTW, the indenting is broken again (also fixed by me). Use tabs not spaces!

I use spaces but these files are full of tabs and I am replacing tabs 
with spaces all the time... So I replaced all tabs with spaces in these 
two functions.  It makes more changes to source code but ensures "no tabs".

I worked on my version of patch again because I have it already in 
Eclipse workspace. I do not see problems with $content in "if" (it works 
ok!) but if you want it out - I did it.

Hopefully, this is the last version. I am pretty bored with this thing :)

Dmitry.
-- 
"It is our choices, that show what we truly are,
far more than our abilities." (A.P.W.B.D.)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 404_v3a.txt
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060623/59ab43e6/attachment.txt 


More information about the TYPO3-team-core mailing list