[TYPO3-core] RFC: fix bug #3600 - config.formMailCharset

[Franz Holzinger]

Hello Martin,

>Franz Holzinger <franz at fholzinger.com> writes on 
>Fri, 30 Jun 2006 18:10:18 +0200 (METDST):
>
>  
>
>
>
>*sigh* I feared such a comment. Did you test the patch?
>
>  
>
I do not understand the renderCharset concept.

It gets initialized in class.tslib_fe.php line 3937


$this->renderCharset =
$this->csConvObj->parse_charset($this->config['config']['renderCharset']
? $this->config['config']['renderCharset'] :
($this->TYPO3_CONF_VARS['BE']['forceCharset'] ?
$this->TYPO3_CONF_VARS['BE']['forceCharset'] :
$this->defaultCharSet));    // Rendering charset of HTML page.

And in class.t3lib_htmlmail.php we now have:

if (!$this->charset) {
    if (is_object($GLOBALS['TSFE']) && $GLOBALS['TSFE']->renderCharset) {
        $this->charset = $GLOBALS['TSFE']->renderCharset;
    } elseif (is_object($GLOBALS['LANG']) && $GLOBALS['LANG']->charSet) {
        $this->charset = $GLOBALS['LANG']->charSet;
    } elseif ($GLOBALS['TYPO3_CONF_VARS']['BE']['forceCharset']) {
        $this->charset = $GLOBALS['TYPO3_CONF_VARS']['BE']['forceCharset'];
    } else {
        $this->charset = $this->defaultCharset;
    }
}

Are there any cases where $GLOBALS['TSFE']->renderCharset has no value?
Probably not because of the line in class.tslib_fe.php:
var $defaultCharSet = 'iso-8859-1';    // The default charset used in
the frontend if nothing else is set.

Otherwise the if above would be unnecessary.

I continue with the test now.

- Franz