[TYPO3-core] Another patch request for t3lib_htmlmail

[Stanislas Rolland]

Hi Michael,
>>> 1. As it seems, your charset related fixes are not working yet:
>>>
>>> +                       // Default charset
>>> +               $this->charset = $this->charset ? $this->charset :
>>> 'iso-8859-1';
>>>       
>> I think it does. You need to set the charset variable of your instance
>> of t3lib_htmlmail to the value you want it to use.
>>     
>
> You are right. It works and I was wrong, but there were probably easier ways
> to write the above output:
>
> if (!$this->charset) $this->charset = 'iso-8859-1';
>   
Fine.
> Anyway, I think this is solved by my patch already.
>   
Unless I read it wrong, it seems that your patch forces the backend charset.
>> Since you are working with a version of dmailer that will not be used in
>> the next version of Direct mail, I am afraid that your patch may fail in
>> the context of Direct Mail.
>>     
>
> OK. I wonder how you will send the mails with that future version? Will you
> still use t3lib_htmlmail in the end?
>   
We moved t3lib_htmlmail to class.dmailer.php in Direct Mail extension.
>>> 3. Why do you set $this->innerMessageid above? It's not used anywhere
>>> else. $this->messageid is also set, that should be enough.
>>>       
>> It is used in setHeaders(). t3lib_dmailer, as well as its replacement
>> class in Direct Mail, may modify $this->messageid and may (I should say
>> will) do so before the headers are set.
>>     
>
> So why don't you add it in t3lib_dmailer instead?
>   
I am afraid I don't understand the problem here. I will just wait for 
your patch and adapt Direct Mail accordingly.

Regards,
Stanislas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060126/9378dfaf/attachment.html