[TYPO3-core] Bugfix #760 GIFBUILDER 256 colors

[Michael Stucki]

Hi Bernhard,

thanks for finishing this great patch. If I remember correctly, that was one
of the most requested Gremlins, and I'm glad to see it will be fixed in
TYPO3 4.0.

> Solution:
> As you can't just increase the size of all images by almost 100% or more
> without any notice I made this option configurable in the Install Tool
> also ([GFX][truecolor]). Internal all operations are truecolor now if GD2
> is available but they get reduced to 256 colors if truecolor was not
> enabled before they get written.

All fine. Here are just some small comments:

- I don't like the property $im_version_4 in t3lib_stdGraphic. Since it is
only used once, I would like to ask you to modify that check and simply
test if $GLOBALS['GFX']['im_version_5'] is false.

- Please add a notice with three !!! in the ChangeLog that the property
$TYPO3_CONF_VARS['GFX']['im_jpg_quality'] has been renamed to
$TYPO3_CONF_VARS['GFX']['jpg_quality'].

- Additionally, I would like to see a check in the update wizard that writes
a warning if the old value is still set in localconf.php (because this will
override the new key all the times...).

- I am still undecided whether the truecolor setting should be enabled by
default or not. Sorry I can't remember anymore: What was the reason for
disabling it by default?


Besides this, I can confirm that the patch is working great and that there
will be no problems with it - thanks to a long testing phase using
bugtracker and XCLASS extension.

+1

Best regards
- michael

PS: The code is beautiful! :-)
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/