[TYPO3-core] RFC fix for bug #1182

[Peter Niederlag]

Hi,

Karsten Dambekalns schrieb:
[...]
> -		if (!$GLOBALS["TYPO3_CONF_VARS"]["BE"]["installToolPassword"])	die("Install Tool deactivated.<BR>You must enable it by setting a password in typo3conf/localconf.php. If you insert the line below, the password will be 'joh316':<BR><BR>\$TYPO3_CONF_VARS[\"BE\"][\"installToolPassword\"] = \"bacb98acf97e0b6112b1d1b650b84971\";<BR><BR>See the document 'installing_upgrading_32b1.pdf' for more info.");
> +		if (!$GLOBALS["TYPO3_CONF_VARS"]["BE"]["installToolPassword"])	die("Install Tool deactivated.<BR>You must enable it by setting a password in typo3conf/localconf.php. If you insert the line below, the password will be 'joh316':<BR><BR>\$TYPO3_CONF_VARS['BE']['installToolPassword'] = 'bacb98acf97e0b6112b1d1b650b84971';");

Why are you still using or keeping double quotes in comparisons and loops?
>  
[...]

>  				reset($GLOBALS["TYPO3_CONF_VARS"]);
>  				$this->messageFunc_nl2br=0;
>  				while(list($k,$va)=each($GLOBALS["TYPO3_CONF_VARS"]))	{
>  					$ext="[".$k."]";
[...]

>							if (t3lib_div::_GP("installToolPassword_md5"))	$value =md5($value);
>  										} else $doit=0;
>  									}
> -									if ($doit && strcmp($GLOBALS["TYPO3_CONF_VARS"][$k][$vk],$value))	$this->setValueInLocalconfFile($lines, '$TYPO3_CONF_VARS["'.$k.'"]["'.$vk.'"]', $value);
> +									if ($doit && strcmp($GLOBALS["TYPO3_CONF_VARS"][$k][$vk],$value))	$this->setValueInLocalconfFile($lines, '$TYPO3_CONF_VARS[\''.$k.'\'][\''.$vk.'\']', $value);
[...]

Other than that: +1

Cheers,
Peter
-- 
Peter Niederlag * Neuer Sandberg 9 * 31535 Neustadt *
Fon (privat): 05036 / 924 100 * Fon (Büro): 05036 / 924 101
Fon (mobil): 0172 / 516 48 55 * Fax 05036 / 924 105
callto:typo3support (skype)
http://www.niekom.de * TYPO3 und EDV Dienstleistungen *
http://www.clown-goli.de * Clown-Comedy-Jonglage-Animation *