[TYPO3-core] RFC: error logging for the Core

[Martin Kutschker]

Martin Kutschker writes on 
Sat, 14 Jan 2006 10:18:17 +0100 (MET):

> Michael Stucki <michael at typo3.org> writes on 
> Sat, 14 Jan 2006 01:17:57 +0100 (MET):
> 
> > 
> > I just had a look at your latest and greatest version of this
> > patch:
> > 
> > There is one line:
> > + list($type,$destination) =
> > explode(',',$log,3);
> > 
> > And the next time:
> > + list($type,$destination,$level) =
> > explode(',',$log,4);
> > 
> > It seems to me that the first line ignores the 3rd parameter (the
> > level). I
> > also wonder why you've set the maximum number of elements to 4 in
> > the 2nd call?!


I split only so many items I need. In init I need only two (level doesn't affect initialization). The number of elements is one more to ignore any rogue parameters.


> > One open point is that the init function is not called yet. I don't
> > think that it is a good idea to open the log at every request.
> > Therefore I suggest to add a global variable which is not set in
> > the beginning.
> > 
> > At the first call of t3lib_div::sysLog() you simply check for this
> > variable and call the init function if this was not done yet...


Done.

Attached patch has also necessay items in config_default.

Ready to go into beta2?

Masi 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-diff
Size: 7562 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060119/4be7fe90/attachment.bin