[TYPO3-core] Patch: duplicate labels in indexed_search

[Dmitry Dulepov]

Hi!

Sebastian Kurfuerst wrote:
> Hi Dmitry,
> 
>>@@ -1915,9 +1923,9 @@
>> 	 * @return	array		Modified template array
>> 	 */
>> 	function makeInfo($row,$tmplArray)	{
>>-		$tmplArray['size'] = $this->pi_getLL('res_size','',1).' '.t3lib_div::formatSize($row['item_size']).'';
>>-		$tmplArray['created'] = $this->pi_getLL('res_created','',1).' '.date('d-m-y',$row['item_crdate']).'';
>>-		$tmplArray['modified'] = $this->pi_getLL('res_modified','',1).' '.date('d-m-y H:i',$row['item_mtime']).'';
>>+		$tmplArray['size'] = t3lib_div::formatSize($row['item_size']).'';
>>+		$tmplArray['created'] = date('d-m-y',$row['item_crdate']).'';
>>+		$tmplArray['modified'] = date('d-m-y H:i',$row['item_mtime']).'';
> 
> Why do you append an empty string here? This was already done before,
> but I don't see any reason for it.

It is not me, I just removed pi_getLL() because it is an error and did not touch
anything else because it is not related to the bug. I do not like mizing various
fixes in one patch - it is too hard to understand what exactly was solved with
the patch.

Code cleanup for this extension should go separately. For example, many places
have exactly this form of pi_getLL (i.e.: pi_getLL($str,'',1)) which is wrong I
think. If one wants to put HTML tags into this string in the TS setup using
_LOCAL_LANG, it will fail.

Also this extension does not follow naming conventions but I do not plan to fix
that too. I only want to fix obvious error which makes extension look strange.

Dmitry.