[TYPO3-core] FYI: working on update wizard / compatibility

[Robert Lemke]

Hi Sebastian,

On Wednesday 21 December 2005 07:58, Sebastian Kurfuerst wrote:

 > I just wanted to tell you that I'm working on the update wizard - and on
 > the compatibility things I talked about on DEV (COMPAT_VERSION).
 > Results will come soon...

Sorry, I just had a look at your code the first time. A few comments:

  - Great idea, good concept!

  - Please adhere to the CGL at least for new code. I especially miss the 
    JavaDoc comments for the functions

  - Please scan your code again if everything is clean, eg. in 
    showChangesNeeded():

	$tableContents = '';
	foreach ($TYPO3_CONF_VARS['SC_OPTIONS']['ext/install']['compat_version'] ... 					
	...
	if ($tableContents)	{
		return '<table>'.$tableContents.'</table>';
	}

     change to:

	$tableContents = '';
	if (is_array($TYPO3_CONF_VARS['SC_OPTIONS']['ext/install']
['compat_version'])) [
		foreach ($TYPO3_CONF_VARS['SC_OPTIONS']['ext/install']['compat_version'] ... 					
         ...
	if (strlen($tableContents)) {
		return '<table>'.$tableContents.'</table>';
	}
	return '';

Thanks again for your contribution!

robert
-- 
Robert Lemke
TYPO3 Association - Research & Development
Member of the board
http://association.typo3.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060104/cef1e552/attachment.pgp