[TYPO3-core] RFC: error logging for the Core

[Martin Kutschker]

Holzinger Franz <franz at fholzinger.com> writes on 
Mon, 02 Jan 2006 22:46:00 +0100 (MET):

> Hello Martin,
> 
> 
> >>+ if (!$file) {
> >>+ die('Cannot open TYPO3 system log: '.$msg);
> >>+ }
> >>I think this should not die here but only return and maybe send an
> >>email to the shop admin.
> >> 
> >>
> >
> >
> >A bit fixed on shops, aren't you? ;-) If we send an email we need
> > another config variable, which I want to avoid. But I prefer the
> > error_log-version anyway.
> > 
> >
> For me TYPO3 is mainly a shop system ;-) .
> I thought we could use both variants, one with DevLog and one with
> error_log ­--> additional parameter. Some people want this the others
> that.


Huh? devLog and sysLog are two distinct functions.


> >Buuuut, which version do you prefer? The one with the fwrite() or the
> > one with the error_log().
> >
> >And what is your general impression of the patch? +1/-1/neutral...
> >
> I want to have both in the same function, then I will give +1.


Why? error_log does also write to a file and we don't need the custom file locking (when typ3 is 3).

See http://www.php.net/manual/en/function.error-log.php

I realized this only after having written variant 1. So it's either or, fwrite and error_log() simply makes no sense.

Masi