[TYPO3-core] RFC: fix for bug #2592
Stanislas Rolland
stanislas.rolland at fructifor.ca
Tue Feb 21 07:43:03 CET 2006
Hi Wolfgang,
>> Type: bugfix
>>
>> Page type "External URL" causes an error (PHP header warning)
>> BT reference: http://bugs.typo3.org/view.php?id=2592
>>
>> This bug is caused by changes of "stanrolland" on Feb 10 17:09:34,
>> so please Stanislas take an indepth look at it.
>> (http://cvs.sourceforge.net/viewcvs.py/typo3/TYPO3core/typo3/sysext/cms/tslib/class.tslib_fe.php?r1=1.104.2.8&r2=1.104.2.9)
>>
Sorry about that.
>
> @see Franz's comments
> and the attached patches.
>
Thanks for the corrections.
Just one comment. I don't think that the jumpUrl should be set again
within function jumpUrl() :
> @@ -2128,9 +2140,7 @@
> * @return void
> */
> function jumpUrl() {
> - if ($extUrl=$this->sys_page->getExtURL($this->page,$this->config['config']['disablePageExternalUrl'])) {
> - $this->jumpurl = $extUrl;
> - }
> + $this->setExternalJumpUrl();
>
I think the above line should (also) be removed.
Then +1 (tested both in the context of External URL page type and of
direct mail click statistics).
Regards,
Stanislas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060221/fa73fa84/attachment.html
More information about the TYPO3-team-core
mailing list