[TYPO3-core] RFC: Avoid double checking of match-conditions

Franz Holzinger franz at fholzinger.com
Fri Feb 17 09:40:21 CET 2006


Hello Michael,

>works.
>
>Result:
>- There were no differences in our pages compared to the old version.
>- Independent if a page is cached or not, the speed-gain was approximately 
>40ms which was approximately 20% of the generation time for a cached page.
>
>
>I am not sure it this justifies such a change. The problem is that I can't 
>guarantee that it is free of bugs, but maybe the only way to find it out will 
>be to test it...?
>
>  
>
That's clear of course.  :-D
Only persons who do something can make errors, however.

> This array is serialized and an md5-hash

---> a md5-hash

> // This array is an identification of the template. If $this->all is
> empty it's because the template-data is not cached, which it must be.

---> if no_cache is set this must not be cached.

> sort($this->all);

This should be left here. It makes sense to have them in good order in
the loops. Doesn't it?


You can enhance this by passing the big arrays only as references:

function &matching($cc)
...
return &$cc;


+1


Greets,

Franz











More information about the TYPO3-team-core mailing list