[TYPO3-core] RFC: removing symlinks - Report

[René Fritz]

Thanks

I'll review the patch tomorrow...

> Additionally, I would like to see a variable used instead of the PATH_tslib
> constant. Instead, define it right before index_ts.php is included.
>
> Reason: As far as I remember, checking for constants is much slower than
> checking for variables. I think Bernhard did some speed checks about this
> some time ago...
>
> So then, this check should be some milliseconds faster:
> +if (PATH_tslib=='') {
> +       die('Cannot find tslib/. Please set path by defining
> $configured_tslib_path in '.basename(PATH_thisScript).'.');
> +}

I don't agree. Constants should be defined as early as possible to make them 
fixed. Speed is not an issue here I think. I would leave it as it is now but 
let's see it as a first version of these scripts.

René

-- 
René Fritz
TYPO3 Association - Active Member
http://association.typo3.org/