[TYPO3-core] RFC: tx_install (html) code cleanup

Michael Stucki michael at typo3.org
Mon Feb 13 09:23:38 CET 2006


Hi René,

> Type: PHP and HTML code cleanup

Great! Was planning to do the same.

> The code itself was not changed, except 2 things:
> - nl2br was used that it produced wrong html. I changed that nl2br will
> not be used when a table tag is in the to be processed content. I think it
> work fine.
> - default font size changed to 1em (instead of 10px). What do you think?

Is good.

> Because a diff would be 50% of the code which is 5000 lines I do not
> attach a patch but the whole file.

I replaced all quotes with single quotes in both files. That way it was
possible at the changes easily.

I've found that you somewhere have a check for

  $GLOBALS['CLIENT']['BROWSER']=='konqu'

Where is this value coming from? Wouldn't it be better to use
t3lib_div::getIndpEnv to find that out?

Besides this, everything is fine.

I think I will give you +2 because I expect that nobody else will review the
change, so I just did it even more detailed... :-)

Regards, michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/



More information about the TYPO3-team-core mailing list