[TYPO3-core] RFC: Permanent login for FE Users

[Bernhard Kraft]

Ingmar Schlecht wrote:

> Implement support for a new checkbox form field "permalogin" for the
> user to decide whether to be logged in permanently or not.

Ok.

Altough I am not quite fine with the default value of "0" which means that FE-Users
have the choice of permalogin by default. I would opt for setting it to -1 meaning
the admin will have to step in when upgrading from a previous version and wanting to
have permalogin instead of "forcing" him to make settings to disable new features ...

 > diff -r -u newloginbox-orig\pi1\class.tx_newloginbox_pi1.php newloginbox\pi1\class.tx_newloginbox_pi1.php
 > --- newloginbox-orig\pi1\class.tx_newloginbox_pi1.php	Mon Aug 28 14:42:49 2006
 > +++ newloginbox\pi1\class.tx_newloginbox_pi1.php	Mon Aug 28 13:44:50 2006
 > @@ -276,13 +277,20 @@
 > ....
> +						($GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] >= 0 ?

The current implementation allows permalogin only when the FE cookie lifetime is manually
set to a value > 0. this means that by deafult (when the user didn't change the lifetime)
it will already be the case that permalogins will not work - but contradicting this case
the permalogin box is still shown in the newloginbox making it unusable ... i opt for changing
the above line to


+   ( ($GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] >= 0) && ($GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'] > 0) ?

+1 from me ... i looked at the code and it is ok ...

How to cope with issue 1 do not exactly know - what is the security policy about new features
in T3 - should they be allowed by default when they allow more rights to visitors or be disabled
by default ?

I would also consider it important that no new box shows up on a login box when the admin performs
an update - if he does not perform an action on his side.


greets,
Bernhard
-- 
----------------------------------------------------------------------
"Freiheit ist immer auch die Freiheit des Andersdenkenden"
Rosa Luxemburg, 1871 - 1919
----------------------------------------------------------------------
[[ http://think-open.at | Open source company ]]