[TYPO3-core] RFC: Whitespaces :-)
Wolfgang Klinger
wolfgang at stufenlos.net
Fri Aug 25 21:10:40 CEST 2006
*hiya!*
On Fri, 25 Aug 2006, Michael Stucki wrote the following:
> Parts of the code look ugly
>
> Solution:
> Apply the patches which I have attached. I've collected those changes during
> the last few weeks, and finally I would like to know if anybody objects to
> them. (Probably some will now remember these notations better in future...)
I don't like some of your rules either, but I'll follow them or better
search for a PHP code formatter to do the hard work ;-).
btw: there's something you should change before submitting
whitespaces2.diff:
-------
function checkRecord($table,$uid,$checkPage=0) {
global $TCA;
- $uid=intval($uid);
- if (is_array($TCA[$table])) {
+ $uid = intval($uid);
+ if (is_array($TCA[$table])) {
$res = $GLOBALS['TYPO3_DB']->exec_SELECTquery('*', $table, 'uid='.intval($uid).$this->enableFields($table));
if ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {
$this->versionOL($table,$row);
-------
There's the "$uid = intval($uid);" line and two lines later
"'uid='.intval($uid)" (tautologous) ;-)
have a nice weekend
bye Wolfgang
More information about the TYPO3-team-core
mailing list