[TYPO3-core] [REMINDER: RFC: more fixes for status=503]

[Ingmar Schlecht]

Hi Dmitry,

I just checked it and it works fine.

Thanks for your good work!

cheers
Ingmar

Dmitry Dulepov wrote:
> Hi!
> 
> This is a reminder for patch below. Bug is critical to tt_news,
> pdf_generator and any other plugin that uses $TSFE->set_no_cache() call.
> 
> I did not get any "+1"s, so cannot commit it.
> 
> Dmitry.
> 
> -------- Original Message --------
> Subject: [TYPO3-core] RFC: more fixes for status=503
> Date: Sun, 09 Apr 2006 17:25:55 +0300
> From: Dmitry Dulepov <dima at spamcop.net>
> Reply-To: TYPO3 core team <typo3-team-core at lists.netfielders.de>
> To: TYPO3 core team <typo3-team-core at lists.netfielders.de>
> 
> Hello!
> 
> This is a CVS patch request.
> 
> Branches: HEAD, TYPO3_4-0
> 
> Symptoms: HTTP status 503 is sent when plugin calls $TSFE->set_no_cache().
> 
> Problem: TSFE did not handle this case properly. Due to the nature of
> the cache, temporary content always comes to the cache before page is
> being actually generated. If set_no_cache is not called, this temporary
> content is replaced with real content. If set_no_cache is called,
> temporary content is left in the database and sent to client during
> subsequent connections.
> 
> Solution: clear temporary content if no_cache is detected.
> 
> See: http://bugs.typo3.org/view.php?id=3049 and
> http://bugs.typo3.org/view.php?id=3176
> 
> Note: commit is pending until merge is complete.
> 
> Dmitry.
> 
> 
> --
> "It is our choices, that show what we truly are,
> far more than our abilities." (A.P.W.B.D.)

------------------------------------------------------------------------

Index: class.tslib_fe.php
===================================================================
RCS file:
/cvsroot/typo3/TYPO3core/typo3/sysext/cms/tslib/class.tslib_fe.php,v
retrieving revision 1.104.2.21
diff -u -r1.104.2.21 class.tslib_fe.php
--- class.tslib_fe.php	25 Mar 2006 18:07:03 -0000	1.104.2.21
+++ class.tslib_fe.php	9 Apr 2006 11:56:29 -0000
@@ -2575,6 +2575,7 @@
 			$this->realPageCacheContent();
 		} elseif ($this->tempContent)	{		// If there happens to be temporary
content in the cache and the cache was not cleared due to new content
put in it... ($this->no_cache=0)
 			$this->clearPageCacheContent();
+            $this->tempContent = false;
 		}

 			// Sets sys-last-change: