[TYPO3-core] RFC: empty SYS[setDBinit] floods error log

Martin Kutschker Martin.Kutschker at blackbox.net
Tue Apr 18 22:02:53 CEST 2006


Dmitry Dulepov <dima at spamcop.net> writes on 
Tue, 18 Apr 2006 21:52:33 +0200 (METDST):

> Hi!
> 
> Martin Kutschker wrote:
> 
> > + if ($v !== '') {
> > + if (mysql_query($v,
> > $this->link) === FALSE) {
> > + 
> > t3lib_div::sysLog('Could not initialize DB connection with query
> > "'.$v.'".','Core',3);
> > + }
> 
> What about this:
> 
> if ($v !== '' && mysql_query(....) === false) {
> ...
> }
> 
> It uses short-circuited boolean evaluation and a bit more compact.


Had it in mind, but didn't like it because it mixes two different checks. But no problem, if more list members favour your version.

Masi




More information about the TYPO3-team-core mailing list