[TYPO3-core] RFC: cropscale fix

[Bernhard Kraft]

Hello,


This is a CVS patch request.

Type: Bugfix

BT reference:
http://bugs.typo3.org/view.php?id=3162


Description:
With 4.0 a new feature was introduced which is called "cropscale". Until now it was possible to add a
"m" to the width/height values/properties of a IMAGE cObj. Now you could instead also add a "c".

Currently there is a problem when an image has alredy the correct size for one of the dimensions and
the other has to get scaled it won't get scaled at all .... the code checks to scale/crop the image only
if dimensions of original and target image are different - but this is not the case when cropping and one
dimension has the correct size.

Stefan Geith the person who contributed this feature to the core has provided a fix in the mentioned BT
entry.

I checked that it works (and how :) and settled that there won't be any side effects by applying the patch.


Solution:
When cropping shall get performed don't just return the original image even if width/height of target are the
same as original.


Files:
cropscale_fix_2006-04-13.diff



greets,
Bernhard
-- 
----------------------------------------------------------------------
"Freiheit ist immer auch die Freiheit des Andersdenkenden"
Rosa Luxemburg, 1871 - 1919
----------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cropscale_fix_2006-04-13.diff
Type: text/x-patch
Size: 872 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060413/6d09576f/attachment.bin