[TYPO3-core] RFC: PHP warning in class.t3lib_tceforms.php

Dmitry Dulepov dima at spamcop.net
Sun Apr 9 16:32:42 CEST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello!

This is a CVS patch request.

Branches: HEAD, TYPO3_4-0

Symptoms: PHP warning may be displayed while editing page record if
record was created by the very old versions of templavoila.

Problem: TCEForms always assume that <meta>-tag in the flexform is array
and do not check if it is really array. The following simple example
causes PHP warning: "<meta> </meta>". Tags were created this way by old
versions of templavoila. This also can happen if flexform created manually.

Solution: check if "meta" is array and if not, set it to empty array
(this is acceptable for the code).

See: http://bugs.typo3.org/view.php?id=3196

FAQ:
Q: Why this needs to be fixed in the code? Looks like templavoila problem.
A: It needs to be fixed in the core because "meta" handling there is
incorrect. Old templavoila just helped to uncover this problem.
Q: How important is this.
A: Not critical at all, but nice to have. Generally cleaning flexforms
resolves this problem (unless you have thousand such flexforms in database).
Q: Does new TV has the same problem
A: I could not reproduce it with new TV versions.

Note: commit is pending until merge is complete.

Dmitry.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEORsKRVcYnKJ8N6kRAqxzAKCZ19CuWQYomCzJYkdOSUZyzier4gCfZMQ0
32dxQVyQjQhzU0lxtZffIpY=
=RZ29
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tceforms_flexforms_meta.txt
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060409/631c3029/attachment.txt 


More information about the TYPO3-team-core mailing list