[TYPO3-core] Accessible PopUp links

Michael Stucki michael at typo3.org
Wed Nov 23 11:16:50 CET 2005

Hi Andreas,

basically the patch is fine. I just have some comments regarding the coding 

- Comments are always indented with a tab
- The content inside of "(...)" brackets should be trimmed (no spaces)
- After "if ()" the "{" bracket is prepended with a tab
- This is not the same for the else statement: Here we usually add a space
  before and after: "} else {"

I know I am a nitpicker, but I like this kind of unity.

- michael

Am Mittwoch, 23. November 2005 09.59 schrieb Andreas Otto:
> Hi Martin,
> On Tuesday 22 November 2005 15:21, Martin Kutschker wrote:
> > Is $finalTagParts['url'] htmlspecialchars'ed already? I notice that
> > $onclick is hsc'ed within the string concatenation.
> The $finalTagParts['url'] was not hsc'ed, it is now.
> I have extended the patch to the method imageLinkWrap(), see attached diff.
> Cheers,
> Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20051123/c736be3d/attachment.pgp 

More information about the TYPO3-team-core mailing list